feat: add --wait flag to compute-envs delete#593
Merged
stefanoboriero merged 5 commits intomasterfrom May 8, 2026
Merged
Conversation
3 tasks
Contributor
|
@robsyme To my knowledge, the Tower CLI functions primarily as a direct interface to our API, so introducing additional logic or complexity at the CLI level may not be the most appropriate approach. If an external tool requires waiting for a delete operation to complete, would it not be more suitable to implement that functionality within the tool itself? |
Contributor
|
While you might have a point there Cristian, this behaviour pattern is already present in tower-cli (for example in LaunchCmd https://github.com/seqeralabs/tower-cli/blob/master/src/main/java/io/seqera/tower/cli/commands/LaunchCmd.java#L90-L91) so I think having it for CE deletion as well fits the current interaction pattern between seqerakit and tower-cli |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Rob Syme <rob.syme@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Rob Syme <rob.syme@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Rob Syme <rob.syme@gmail.com>
There is common logic to wait for given resource status, this commit leverages that instead of custom logic for CE deletion.
stefanoboriero
force-pushed
the
fd7252-delete-wait
branch
from
4882c7d to
ce11e28
Compare
stefanoboriero
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--waitboolean flag totw compute-envs deletedescribeComputeEnv()until the CE is fully removed (404) or entersERROREDstatewaitStatuspattern)Context
Forge CE deletion is async since Dec 2025 (commit
be99dcf9b9). The CE stays inDELETINGstatus for ~2 minutes while AWS resources are cleaned up. Tools like seqerakit that delete-then-recreate CEs (on_exists: overwrite) need to wait for deletion to complete before creating the replacement.Related: FD-7252, platform#10680
Test plan
testDeleteWaitHappyPath: DELETE 204 -> poll DELETING -> poll 404 -> exit 0testDeleteWaitErrored: DELETE 204 -> poll ERRORED -> exit 1testDelete,testDeleteInvalidAuth,testDeleteNotFound)🤖 Generated with Claude Code